phpbb-auction.com Forum Index phpbb-auction.com
Download, Support, Documentation
 
Donate to phpbb-auction.com to support the project


phpbb-Auction
  Home
   - News
   - Bug report/Patches
   - Future Features
  Demo
  Downloads
   - Version 1.3m  (Core /Lang /Mods)
   - Version 1.2m  (Core /Lang /Mods)
   - Version 1.0m  (Core /Lang /Mods)
   - All
  Services
  Documentation
   - Features
   - Documents
   - How-Tos
   - About
  Support
   - English
   - German
  Development
   - Changlog
   - Requests
   - Team
   - CVS
  Community
   - Website of the Month
   - Websites
   - Community Forum
   - Member

Navigation
FAQFAQ
SearchSearch
UsergroupsUsergroups
RegisterRegister
ProfileProfile
Log in to check your private messagesLog in to check your private messages
Log inLog in

Forum
Changing start time auctions
Sun Feb 07, 2010 4:33 am FR
Easy: what code to use to update sql table?
Fri Oct 16, 2009 8:39 am guyb
Unlimited products(downloads)
Wed Oct 14, 2009 7:09 pm hoimyr
Seller chooses currency
Sun Oct 11, 2009 8:00 pm hoimyr
Cant select end date without getting error
Sun Oct 11, 2009 6:43 pm hoimyr

About
Author: FR
Credits:
Brookfresh, Brad Lawryk, Crogon, DaMysterious, EklipzeDesigns, ML, musashi, phpBB Group, phpBB-Auction-Team, php-styles, sanman, Tel, Vampy, wGEric

Supported Sites





Statistics
User: 17929
Posts: 18401
Latest User: charleneza2

PM notification not working - Patch inside!
Goto page 1, 2  Next
 
Post new topic   Reply to topic    phpbb-auction.com Forum Index -> Development
View previous topic :: View next topic  
Author Message
HonestJohn
Small-Cap Auctioneer
Small-Cap Auctioneer


Joined: 15 Aug 2004
Posts: 48

PostPosted: Fri Aug 20, 2004 3:03 am    Post subject: PM notification not working - Patch inside! Reply with quote

On both an upgraded and a virgin install, the PM notification system is not working.
It's not generating any errors, it's simply not sending the PM's.
I haven't looked at it in depth yet, I'm just wondering if anyone else has had this problem?


Last edited by HonestJohn on Fri Aug 20, 2004 2:28 pm; edited 3 times in total
Back to top
View user's profile Send private message
flyguy9478
Small-Cap Auctioneer
Small-Cap Auctioneer


Joined: 15 Aug 2004
Posts: 29

PostPosted: Fri Aug 20, 2004 3:12 am    Post subject: Reply with quote

yeah i do, i posted it already Very Happy
Back to top
View user's profile Send private message
HonestJohn
Small-Cap Auctioneer
Small-Cap Auctioneer


Joined: 15 Aug 2004
Posts: 48

PostPosted: Fri Aug 20, 2004 3:19 am    Post subject: Reply with quote

Right, didn't see your post under the cron issues.
Whatever is wrong should be a fairly simple fix I'm guessing, but I haven't been able to find the issue.
I'm having the same issue you are, except no PM's are being sent by phpbb auction at all (oubid or winning bid).
1.0 was functioning fine, and I see little difference in the code, so I was assuming it's a trigger somewhere that isn't going, but I haven't had time to look hard.
Back to top
View user's profile Send private message
flyguy9478
Small-Cap Auctioneer
Small-Cap Auctioneer


Joined: 15 Aug 2004
Posts: 29

PostPosted: Fri Aug 20, 2004 3:36 am    Post subject: Reply with quote

open auction_cron.php in your browser and see if the auction end notifications get sent
Back to top
View user's profile Send private message
HonestJohn
Small-Cap Auctioneer
Small-Cap Auctioneer


Joined: 15 Aug 2004
Posts: 48

PostPosted: Fri Aug 20, 2004 3:43 am    Post subject: Reply with quote

That gives me a blank page.
I only skimmed your cron thread, it looks like you found some answers there, I just have to figure out what cron is and what im going to do with it Wink

Although it would be nice if the auction_offer.php PM notification was working...
Back to top
View user's profile Send private message
flyguy9478
Small-Cap Auctioneer
Small-Cap Auctioneer


Joined: 15 Aug 2004
Posts: 29

PostPosted: Fri Aug 20, 2004 3:53 am    Post subject: Reply with quote

yeah it's supposed to be a blank page. that file sends out the auction end notifications, but NOT the outbid notifications. after one of your auctions ends, open that file in your browser and it will send out the proper notification. then check your e-mail and you will have a letter in your inbox.
Back to top
View user's profile Send private message
HonestJohn
Small-Cap Auctioneer
Small-Cap Auctioneer


Joined: 15 Aug 2004
Posts: 48

PostPosted: Fri Aug 20, 2004 4:12 am    Post subject: Reply with quote

Thanks, I'll give that a try.

I'd still like to get auction_offer.php working properly, I don't see what's changed since 1.0. But auction-end notifications are at least more important than outbid notices, so that'll do for now.

If anyone finds a fix for auction_offer, I'd love to know...
Back to top
View user's profile Send private message
FR
Site Admin
Site Admin


Joined: 26 Jan 2004
Posts: 1764
Location: root directory

PostPosted: Fri Aug 20, 2004 7:30 am    Post subject: Reply with quote

the pm-notification works for me... Rolling Eyes
_________________
Want to say thank you. Use my Amazon Wishlist
Meet the world on movie-on.com
Back to top
View user's profile Send private message Send e-mail Visit poster's website MSN Messenger
HonestJohn
Small-Cap Auctioneer
Small-Cap Auctioneer


Joined: 15 Aug 2004
Posts: 48

PostPosted: Fri Aug 20, 2004 7:35 am    Post subject: Reply with quote

FR wrote:
the pm-notification works for me... Rolling Eyes


It did in version 1.0, but it doesn't seem to work on any install (2 different sites), and several people are reporting this problem?

Very nice package btw - I've got a ton of users that are DIEING to have an auction on their site, this will be a huge relief. I just wish I had the PM notifications.

Will look more closely...
Back to top
View user's profile Send private message
flyguy9478
Small-Cap Auctioneer
Small-Cap Auctioneer


Joined: 15 Aug 2004
Posts: 29

PostPosted: Fri Aug 20, 2004 7:51 am    Post subject: Reply with quote

I'm in the same boat as HonestJohn. The outbid notifications worked fine for me in 1.0, but now it is messed up. FR, I saw your post before about how you had to reupload the install files to SourceForge because it was originally corrupted. I just downloaded the full install today, I wiped all of the files that I put on before and cleared out the mysql tables that were used for the auction system, then I started over again from scratch with the 1.2 full install. It still doesn't work though. I am using version 2.0.8 of phpBB, perhaps that has something to do with it? As I mentioned in my other post, I took the PM notify code from 1.0 and inserted it into 1.2, but it still didn't work. There has to be something else in the 1.2 code that is messing it up because that code worked fine when I had the complete 1.0 installed. My site is http://www.glassedgraphix.com/forums/auction.php in case you guys wanna go try making 2 accounts and outbidding yourself so that you can see it doesn't work. I do have it enabled in the ACP so that isn't the problem.
Back to top
View user's profile Send private message
flyguy9478
Small-Cap Auctioneer
Small-Cap Auctioneer


Joined: 15 Aug 2004
Posts: 29

PostPosted: Fri Aug 20, 2004 7:55 am    Post subject: Reply with quote

ummm FR... I just went and outbid myself on your demo site and I have some bad news... it didn't work there either. Shocked
Back to top
View user's profile Send private message
HonestJohn
Small-Cap Auctioneer
Small-Cap Auctioneer


Joined: 15 Aug 2004
Posts: 48

PostPosted: Fri Aug 20, 2004 8:22 am    Post subject: Ok, closer to finding the problem Reply with quote

In auction_offer.php there is a problem associated with the use of 'FK_auction_offer_last_bid_user_id' in the PM notification script.

Around line 1280
if ( $auction_corresponding_bids_start_stop_row['FK_auction_offer_last_bid_user_id'] <> 0 &&
$auction_corresponding_bids_start_stop_row['FK_auction_offer_last_bid_user_id'] <> $userdata['user_id'])

This statement is meant to not send a PM if I outbid myself (or it's the first bid). However $auction_corresponding_bids_start_stop_row['FK_auction_offer_last_bid_user_id'] is updating somewhere in the file to become the last bidder (which was me, if I just bid on an auction), so the PM script will never run, $auction_corresponding_bids_start_stop_row['FK_auction_offer_last_bid_user_id'] is always = $userdata['user_id'] (my user id)


If I remove that restriction, and attempt to let the PM script send as normal, this happens:


privmsgs_to_userid = $auction_corresponding_bids_start_stop_row['FK_auction_offer_last_bid_user_id'] = the last bidder, but because this updates before the PM goes out, so the last bidder is in fact ME (who just bid), the PM gets sent to me, instead of the person who was outbid.




This is what's occurring on my install. I've got a new, full install of all the files, and I did not edit the code related to this.
It's late and I'm not sure how much sense this made, so please let me know if it needs clarification.
Back to top
View user's profile Send private message
FR
Site Admin
Site Admin


Joined: 26 Jan 2004
Posts: 1764
Location: root directory

PostPosted: Fri Aug 20, 2004 12:09 pm    Post subject: Reply with quote

Think i got a patch.
Can anybody try it please:

Open auction_offer.php

Code:
FIND and DELETE

                 // Check start and stop of offer
                 $sql = "SELECT auction_offer_title,
                                FK_auction_offer_last_bid_user_id
                         FROM " . AUCTION_OFFER_TABLE . "
                         WHERE PK_auction_offer_id= " . $HTTP_GET_VARS[POST_AUCTION_OFFER_URL] . "";

                 if( !($result = $db->sql_query($sql)) )
                     {
                          message_die(GENERAL_ERROR, 'Could not query auction-start and stop date', '', __LINE__, __FILE__, $sql);
                     } // if

                 $auction_corresponding_bids_start_stop_row = $db->sql_fetchrow($result);


FIND

                 // Charge points if payment-system is activated
                 if ( $auction_config_data['auction_paymentsystem_activate_user_points'] == 1)
                      {
                           // Step 1: Charge points of bidder

ADD BEFORE

                 // Check start and stop of offer
                 $sql = "SELECT auction_offer_title,
                                FK_auction_offer_last_bid_user_id
                         FROM " . AUCTION_OFFER_TABLE . "
                         WHERE PK_auction_offer_id= " . $HTTP_GET_VARS[POST_AUCTION_OFFER_URL] . "";

                 if( !($result = $db->sql_query($sql)) )
                     {
                          message_die(GENERAL_ERROR, 'Could not query auction-start and stop date', '', __LINE__, __FILE__, $sql);
                     } // if

                 $auction_corresponding_bids_start_stop_row = $db->sql_fetchrow($result);

_________________
Want to say thank you. Use my Amazon Wishlist
Meet the world on movie-on.com
Back to top
View user's profile Send private message Send e-mail Visit poster's website MSN Messenger
HonestJohn
Small-Cap Auctioneer
Small-Cap Auctioneer


Joined: 15 Aug 2004
Posts: 48

PostPosted: Fri Aug 20, 2004 2:26 pm    Post subject: Reply with quote

Bingo. That works, tested it under a number of different cases, worked properly every time.

I hate smileys but Very Happy Very Happy Very Happy Very Happy Wink

Vielen dank, FR


/edit I have not tested auction-end notifications however...
Back to top
View user's profile Send private message
flyguy9478
Small-Cap Auctioneer
Small-Cap Auctioneer


Joined: 15 Aug 2004
Posts: 29

PostPosted: Fri Aug 20, 2004 4:53 pm    Post subject: Reply with quote

WAY TO GO FR!!! YOU DA' MAN!!! The entire script runs perfectly now, I can't find one thing wrong with it. All of my PM and email notices for outbid and auction end notifications are getting sent out perfectly.

HonestJohn: Does your host use CPanel? If so I can tell you how to get the auction end notifications working automatically. Someone showed me yesterday
Back to top
View user's profile Send private message
Display posts from previous:   
Post new topic   Reply to topic    phpbb-auction.com Forum Index -> Development All times are GMT
Goto page 1, 2  Next
Page 1 of 2

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum


phpbb-auction.com - Developed by www.digital-media-lab.com
Sponsored by: www.globibo.com - www.learn2go.de - www.talentone.org - www.language-school.in - www.ping-ke.cn