phpbb-auction.com Forum Index phpbb-auction.com
Download, Support, Documentation
 
Donate to phpbb-auction.com to support the project


phpbb-Auction
  Home
   - News
   - Bug report/Patches
   - Future Features
  Demo
  Downloads
   - Version 1.3m  (Core /Lang /Mods)
   - Version 1.2m  (Core /Lang /Mods)
   - Version 1.0m  (Core /Lang /Mods)
   - All
  Services
  Documentation
   - Features
   - Documents
   - How-Tos
   - About
  Support
   - English
   - German
  Development
   - Changlog
   - Requests
   - Team
   - CVS
  Community
   - Website of the Month
   - Websites
   - Community Forum
   - Member

Navigation
FAQFAQ
SearchSearch
UsergroupsUsergroups
RegisterRegister
ProfileProfile
Log in to check your private messagesLog in to check your private messages
Log inLog in

Forum
Changing start time auctions
Sun Feb 07, 2010 4:33 am FR
Easy: what code to use to update sql table?
Fri Oct 16, 2009 8:39 am guyb
Unlimited products(downloads)
Wed Oct 14, 2009 7:09 pm hoimyr
Seller chooses currency
Sun Oct 11, 2009 8:00 pm hoimyr
Cant select end date without getting error
Sun Oct 11, 2009 6:43 pm hoimyr

About
Author: FR
Credits:
Brookfresh, Brad Lawryk, Crogon, DaMysterious, EklipzeDesigns, ML, musashi, phpBB Group, phpBB-Auction-Team, php-styles, sanman, Tel, Vampy, wGEric

Supported Sites





Statistics
User: 17714
Posts: 18401
Latest User: tamragk18

[MOD/FIX] Proper Refresh in Pics Manager after deleting pics

 
Post new topic   Reply to topic    phpbb-auction.com Forum Index -> Development
View previous topic :: View next topic  
Author Message
ssimon
Mid-Cap Auctioneer
Mid-Cap Auctioneer


Joined: 21 Aug 2004
Posts: 62

PostPosted: Mon Sep 13, 2004 8:24 am    Post subject: [MOD/FIX] Proper Refresh in Pics Manager after deleting pics Reply with quote

OK, the issue with the lack of refresh in the Pics Manager was finally tracked down. I had posted about this problem, & asking for help earlier HERE

Basically it all boiled down yet again to a single line of code that needs to be added so the Pics Manager displays the correct # of pics currently uploaded after the deletion of one of them, and how many you have left to upload.

FIND in auction_pics_manager.php around line 1034
Code:
         if( !$result = $db->sql_query($sql) )
            message_die(GENERAL_ERROR, "Couldn't delete coupon picture. Please try again.", "", __LINE__, __FILE__, $sql);

AFTER, ADD
Code:
// MOD BEGIN - ssimon - Fix refresh after delete --
redirect(append_sid("auction_pics_manager.$phpEx?ao=$offer_id"));
// MOD END - ssimon - Fix refresh after delete --

Now the page will refresh properly when returning from the delete ackgnowlegenment (pressing YES).

FR, you might want to add that line for the next version Laughing

BTW FR, that SQL error message is improperly "labled" it should be: "Couldn't delete image. Please try again." NOT "Couldn't delete coupon picture. Please try again." It threw me off for a while Laughing

Anyway, try the pics manager without my fix and with and you'll see the difference.

Enjoy!

Steve.
________
Ford Mondeo V6 engine


Last edited by ssimon on Mon Jan 31, 2011 8:44 pm; edited 2 times in total
Back to top
View user's profile Send private message
Crogon
Moderator
Moderator


Joined: 17 May 2004
Posts: 574
Location: Anywhere I'm needed.. which is usually everywhere. ;)

PostPosted: Mon Sep 13, 2004 8:48 am    Post subject: Reply with quote

Please don't be discouraged, but first off, the orignal author of this mod would have to have been a total idiot not to include a redirect. By inserting this you are very likely doing one of the two following things:

a) stopping the script from finishing necessary functionality before it attempts to return to the page

b) ignoring the mode=delete which was in the original link ie:

Code:
.../auction_pics_manager.php?[b]mode=delete[/b]&ao=XX&pic_id=YY


While this may 'fix' the perceived problem, it is very likely causing others. I don't mean to deter you, I simply want to caution you to double check what you are doing and why before submitting it as a bug fix. While it is fine to submit unconfirmed code here in the dev forum, redirecting people from the bug forum to try unconfirmed code may not be such a good idea. Wink

Also, I am concerned about that missing mode bit in the link. Note I haven't looked at the original code, and I don't intend to, I just wanted to offer a bit of insight. Smile
Back to top
View user's profile Send private message
ssimon
Mid-Cap Auctioneer
Mid-Cap Auctioneer


Joined: 21 Aug 2004
Posts: 62

PostPosted: Mon Sep 13, 2004 8:58 am    Post subject: Reply with quote

Thanks Crogon, I appreciate your feedback. I sincerely hope you did not missunderstand my comments as offensive or aggressive. It was NOT my intention.

However, I noticed from one of your earlier posts that you did not yet experiment with the new v1.2m and thus are not aware of all the "issues".

I was very carefull in the placement of my code fix and it was added to the END of the "mode=delete" case statement, after the image was deleted. There was NO more processing to be done!

Also please keep in mind that my MOD/FIX "suggestions" are being placed in "Area 51" hence FR will have a crack at them BEFORE includding any of them in the next version or certifying them as valid.

I am only giving something back as this script was free and I like to contribute.

Steve.
________
buy glass pipes


Last edited by ssimon on Mon Jan 31, 2011 8:44 pm; edited 1 time in total
Back to top
View user's profile Send private message
Crogon
Moderator
Moderator


Joined: 17 May 2004
Posts: 574
Location: Anywhere I'm needed.. which is usually everywhere. ;)

PostPosted: Mon Sep 13, 2004 10:06 am    Post subject: Reply with quote

You are absolutely correct!! Cool

I have not had a chance to play around with the new version yet. All I'm doing at this point is pointing out common things that people may have missed. Most of the time they have already thought of it, but once in a while.. Wink

Either way FR or possibly Auctioneer should confirm all code changes / bug fixes. God knows I can't, I haven't even installed the new one yet, lol.
Back to top
View user's profile Send private message
Display posts from previous:   
Post new topic   Reply to topic    phpbb-auction.com Forum Index -> Development All times are GMT
Page 1 of 1

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum


phpbb-auction.com - Developed by www.digital-media-lab.com
Sponsored by: www.globibo.com - www.learn2go.de - www.talentone.org - www.language-school.in - www.ping-ke.cn